fix(cli): validate arg count for artifact tags create/delete to preve… - #1071
Open
mantrapatel05 wants to merge 1 commit into
Open
mantrapatel05 wants to merge 1 commit into
mantrapatel05 wants to merge 1 commit into
Conversation
mantrapatel05
force-pushed
the
fix/artifact-tags-args-panic-clean
branch
from
July 27, 2026 16:23
66c676f to
6ebf1a2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1071 +/- ##
=========================================
- Coverage 10.99% 9.54% -1.45%
=========================================
Files 173 321 +148
Lines 8671 16097 +7426
=========================================
+ Hits 953 1536 +583
- Misses 7612 14427 +6815
- Partials 106 134 +28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mantrapatel05
force-pushed
the
fix/artifact-tags-args-panic-clean
branch
2 times, most recently
from
July 27, 2026 16:37
888d6b6 to
6c5b3e6
Compare
…nt panic Signed-off-by: Mantra Patel <patelmantra551@gmail.com>
mantrapatel05
force-pushed
the
fix/artifact-tags-args-panic-clean
branch
from
July 27, 2026 16:53
6c5b3e6 to
94250f3
Compare
qcserestipy
requested review from
qcserestipy
and
a balanced review from Copilot
September 1, 2026 08:04
qcserestipy
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents artifact tag create/delete commands from panicking on invalid argument counts.
Changes:
- Allows only 0 or 2 positional arguments.
- Returns a validation error for all other counts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
create.go |
Validates create-command arguments. |
delete.go |
Validates delete-command arguments. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if len(args) == 0 || len(args) == 2 { | ||
| return nil | ||
| } | ||
| return fmt.Errorf("requires either 0 arguments(interactive mode) or 2 arguments(<project>/<repository>/<reference> <tag>), got %d", len(args)) |
qcserestipy
requested changes
Sep 1, 2026
qcserestipy
left a comment
qcserestipy
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for your contribution! lgtm
qcserestipy
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
harbor artifact tags create and delete both panic with an "index out of range" error
when called with exactly one argument. Neither command had an Args validator on the
cobra.Command, so passing a single arg fell into the non-interactive branch and tried
to read args[1], which doesn't exist.
Type of Change
Please select the relevant type.
Changes