fix: widen Integer to Long in castValue() for boxed Long parameter#1290
Open
jjhz wants to merge 1 commit into
Open
fix: widen Integer to Long in castValue() for boxed Long parameter#1290jjhz wants to merge 1 commit into
jjhz wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
|
Hi @jjhz, thank you for your contribution! We appreciate you taking the time to submit this pull request. Currently this PR is under review by our team, we will keep you posted if any additional information is required. thank you. |
Contributor
|
@krwc, Could you please review this PR. |
7d6b79f to
7644a17
Compare
7644a17 to
bc32948
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Testing Plan
Unit Tests:
Two new tests added to
FunctionToolTest:call_withPrimitiveLongParam_whenModelProvidesInteger_succeeds— confirms primitivelongwas never broken (Java reflection auto-widensint→long); serves as a regression guard.call_withBoxedLongParam_whenModelProvidesInteger_succeeds— directly reproduces the bug: passesInteger(42)as the arg for a boxedLongparameter (exactly what Jackson produces when deserializing the model's small integer), and asserts the tool returns42Lcorrectly.Manual End-to-End (E2E) Tests:
The bug is fully exercised by the unit tests above, which simulate exactly what the ADK framework does at runtime: Jackson deserializes a small JSON integer as
Integer, the framework passes it unchanged intotool.runAsync(), andcastValue()must widen it toLongbefore reflection invokes the tool method. No additional E2E setup is required to observe the fix.Checklist