[Kotlin] Fix required union accessors - #9219
Open
mjmahone wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
python
c++
codegen
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Required union accessors have non-null return types, but their missing-field branch currently returns null. This produces Kotlin code that does not compile. Throw an AssertionError for absent required unions, matching required string accessors, and add a focused code-generation regression test.
mjmahone
force-pushed
the
fix-kotlin-required-union
branch
from
September 2, 2026 20:05
2d721ee to
60111ec
Compare
mjmahone
marked this pull request as ready for review
September 2, 2026 20:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nullfor optional union fields.Why
Required union accessors have a non-null return type, but their missing-field branch currently returns
null. As a result, schemas containing required unions generate Kotlin that does not compile. The new behavior matches the existing handling for required string accessors.Test
flatcsource with Clang.KotlinTests.RequiredUnionregression test.Tablereturn type and throwsAssertionErrorwhen the field offset is absent.