Migrate off archived actions-rs/clippy-check - #838
Open
IncognitoQuack wants to merge 2 commits into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot I signed it! |
The actions-rs org has been archived since 2023, so its actions no longer get updates or security fixes. Switch the clippy job to clechasseur/rs-clippy-check, a maintained fork of the same action. It takes the same args input, so the lints that run are unchanged. The token input is dropped because it no longer exists: the fork reports lints through workflow annotation commands instead of the checks API. That also makes the job's checks: write permission unnecessary, so it goes too. Fixes google#665
IncognitoQuack
force-pushed
the
fix/migrate-clippy-check-action
branch
from
September 3, 2026 12:01
aa0f5b9 to
abde0e3
Compare
Set persist-credentials: false on every actions/checkout step so the job token is not left behind in .git/config after checkout, and narrow the top-level read-all permissions to contents: read, which is all any job in this workflow needs. Together with the clippy action migration this brings zizmor to a clean scan (0 findings), where main currently reports 10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actions-rs org has been archived since 2023, so its actions no longer get updates or security fixes.
Switch the clippy job to clechasseur/rs-clippy-check, a maintained fork of the same action. It takes the same args input, so the lints that run are unchanged.
The token input is dropped because it no longer exists: the fork reports lints through workflow annotation commands instead of the checks API. That also makes the job's checks: write permission unnecessary, so it goes too.
Fixes #665