Skip to content

Implement LOI property generator for GeoIDs - #2484

Merged
rfontanarosa merged 21 commits into
masterfrom
rfontanarosa/2438/possibility-to-enable-or-disable-integrated-services-3
Sep 3, 2026
Merged

Implement LOI property generator for GeoIDs#2484
rfontanarosa merged 21 commits into
masterfrom
rfontanarosa/2438/possibility-to-enable-or-disable-integrated-services-3

Conversation

@rfontanarosa

@rfontanarosa rfontanarosa commented Apr 3, 2026

Copy link
Copy Markdown
Collaborator

closes #2438
closes #1537
closes #2113

Screenshot 2026-09-03 alle 15 57 13

@rfontanarosa rfontanarosa self-assigned this Apr 3, 2026
@rfontanarosa rfontanarosa changed the title Rfontanarosa/2438/possibility to enable or disable integrated services 3 Implement GeoID integration Apr 3, 2026
@rfontanarosa
rfontanarosa marked this pull request as ready for review April 16, 2026 13:34
@auto-assign
auto-assign Bot requested a review from gino-m April 16, 2026 13:34

@gino-m gino-m left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the PR description to something a bit more self-descriptive, e.g., "Implement property generator for GeoIDs"

Comment thread functions/src/property-generators/geoid.ts
Comment thread functions/src/property-generators/geoid.ts Outdated
Comment thread functions/src/on-create-loi.ts Outdated
@codecov-commenter

codecov-commenter commented Apr 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.94%. Comparing base (ff21f01) to head (b987d07).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2484   +/-   ##
=======================================
  Coverage   62.94%   62.94%           
=======================================
  Files         121      121           
  Lines        3006     3006           
  Branches      457      457           
=======================================
  Hits         1892     1892           
  Misses       1048     1048           
  Partials       66       66           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rfontanarosa rfontanarosa changed the title Implement GeoID integration Implement LOI property generator for GeoIDs Apr 17, 2026
@rfontanarosa
rfontanarosa requested a review from gino-m April 17, 2026 07:26
@gino-m

gino-m commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Doesn't WHISP already issue geoIDs? Why do we need a separate generator for GeoIDs?

@jo-spek

jo-spek commented May 22, 2026

Copy link
Copy Markdown
Collaborator

Doesn't WHISP already issue geoIDs? Why do we need a separate generator for GeoIDs?

GeoIDs are supposed to be the ultimate pilar of interoperability. So that a geometry created in Ground can easily be loaded elsewhere without having to export import. If you would generate GeoIDs in Whisp, you would have to manually export-import from Ground to Whisp. We want any newly created geometry to have a GeoID immediately.

…-disable-integrated-services-3

# Conflicts:
#	functions/src/common/datastore.ts
#	functions/src/on-create-loi.ts
gino-m
gino-m previously approved these changes Jul 31, 2026
@rfontanarosa
rfontanarosa requested a review from gino-m September 3, 2026 14:54
@rfontanarosa
rfontanarosa merged commit bee1e1e into master Sep 3, 2026
14 checks passed
@rfontanarosa
rfontanarosa deleted the rfontanarosa/2438/possibility-to-enable-or-disable-integrated-services-3 branch September 3, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants