Skip to content

ci: run Compose Preview Screenshot Tests in PullRequestWorkflow - #585

Open
temcguir wants to merge 2 commits into
mainfrom
temcguir/enable-screenshot-tests-ci
Open

temcguir wants to merge 2 commits into
mainfrom
temcguir/enable-screenshot-tests-ci

Conversation

@temcguir

@temcguir temcguir commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Adds validateScreenshotTest to the Unit Tests job in .github/workflows/PullRequestWorkflow.yaml so host-side Compose Preview Screenshot Tests run on pull requests alongside unit tests.
  • Updates the test-reports failure artifact upload step to use recursive globs (**/build/reports/tests and **/build/reports/screenshotTest) so HTML failure reports from nested submodules (e.g., ui/components/capture and feature/*) and screenshot diff reports are uploaded when a test fails.
  • Hardens PullRequestWorkflow.yaml to satisfy GitHub Actions security scanning: pins third-party actions to full 40-character commit SHAs, declares least-privilege permissions blocks, and sets persist-credentials: false on checkout steps.

Add validateScreenshotTest to the Unit Tests job in PullRequestWorkflow.yaml so host-side Compose Preview Screenshot Tests run on pull requests alongside unit tests.

Also update the test-reports failure artifact upload paths to use recursive globs (**/build/reports/tests and **/build/reports/screenshotTest) so HTML failure reports from nested submodules and screenshot diff reports are uploaded when a test fails.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Pin third-party GitHub Actions to full 40-character commit SHAs, declare least-privilege permissions blocks at the workflow and job levels, and disable git credential persistence in checkout steps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant