Skip to content

parser: support Python-style implicit string concatenation #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rnvibes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

parser: support Python-style implicit string concatenation #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion include/minja/minja.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1806,7 +1806,28 @@ class Parser {
if (it == end) return nullptr;
if (*it == '"' || *it == '\'') {
auto str = parseString();
if (str) return std::make_shared<Value>(*str);
if (str) {
// Python-style implicit string concatenation: adjacent string
// literals ("a" "b") fold into one ("ab"). Jinja (and the Gemini/
// Gemma templates that embed tool-call error messages) relies on it;
// Minja's parser rejected the multi-line call-arg form.
while (it != end) {
auto save = it;
consumeSpaces();
if (it != end && (*it == '"' || *it == '\'')) {
auto next = parseString();
if (!next) {
it = save;
break;
}
*str += *next;
} else {
it = save;
break;
}
}
return std::make_shared<Value>(*str);
}
}
static std::regex prim_tok(R"(true\b|True\b|false\b|False\b|None\b)");
auto token = consumeToken(prim_tok);
Expand Down