Conversation
When the instrumentation run crashes after some INSTRUMENTATION_STATUS lines but before the INSTRUMENTATION_STATUS_CODE line, the parser called _parse_result_line, which does not exist, so the run failed with an AttributeError instead of reporting the crash. Call _parse_result_block_line instead.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an instrumentation run crashes after some
INSTRUMENTATION_STATUSlines but before theINSTRUMENTATION_STATUS_CODEline,_parse_method_block_linecallsself._parse_result_line, which does not exist, so the test fails with anAttributeErrorinstead of reporting the crash. This calls_parse_result_block_lineinstead. The added test with a status block followed directly by anINSTRUMENTATION_RESULTline fails before the change and passes after, and pyink is clean on the changed files.