Prevent calling as_base_types on class objects in openhtf.util.data. - #1325
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_963431550
branch
2 times, most recently
from
August 13, 2026 00:23
bfb975e to
189e0e7
Compare
Update openhtf.util.data to check that an object is not a class before calling its as_base_types method. This ensures that class objects themselves are converted to their string representations instead of attempting to call the method on the class. Also add corresponding unit tests. PiperOrigin-RevId: 963749692
copybara-service
Bot
force-pushed
the
test_963431550
branch
from
August 13, 2026 00:29
189e0e7 to
9bfeea8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent calling as_base_types on class objects in openhtf.util.data.
Update openhtf.util.data to check that an object is not a class before calling its as_base_types method. This ensures that class objects themselves are converted to their string representations instead of attempting to call the method on the class. Also add corresponding unit tests.