fix: remove empty fragments directories from packaged output - #854
Open
amarkdotdev wants to merge 1 commit into
Open
fix: remove empty fragments directories from packaged output#854amarkdotdev wants to merge 1 commit into
amarkdotdev wants to merge 1 commit into
Conversation
Delete fragment sources after post-processing injection and prune any leftover fragments/ tree before tarring so packages no longer ship empty directory hierarchies. Signed-off-by: amarkdotdev <amarkdotdev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fragments/after fragment injection in the post-processor.fragments/tree inphp_gapic_pkg.bzlbefore creating the package tarball.Fixes #621
Notes
Test plan
FragmentInjectionProcessorTestfragments/directories