chore: Update Google.Backstory to be a proto only library#15768
chore: Update Google.Backstory to be a proto only library#15768efevans wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request converts the Google.Backstory library from a GAPIC client to a proto-only library, removing the generated snippet projects and updating the generator configuration. The reviewer suggests removing the unnecessary dependency on Google.Api.Gax.Grpc from both apis.json and the project file, as proto-only libraries do not require it.
| "dependencies": { | ||
| "Google.Api.Gax.Grpc": "default" | ||
| }, |
There was a problem hiding this comment.
Since Google.Backstory is being updated to a proto-only library ("generator": "proto"), it should not depend on Google.Api.Gax.Grpc, which is a library for GAPIC clients. If the library only contains protobuf messages, it does not need any extra dependencies (as Google.Protobuf is added automatically). If it contains gRPC services, it should depend on Grpc.Core.Api instead.
"dependencies": {},| <ItemGroup> | ||
| <PackageReference Include="ConfigureAwaitChecker.Analyzer" PrivateAssets="All" /> | ||
| <PackageReference Include="Google.Api.Gax.Grpc" /> | ||
| <PackageReference Include="Grpc.Core" PrivateAssets="None" Condition="'$(TargetFramework)'=='net462'" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Remove the unnecessary dependency on Google.Api.Gax.Grpc since this is now a proto-only library.
<ItemGroup>
<PackageReference Include="ConfigureAwaitChecker.Analyzer" PrivateAssets="All" />
</ItemGroup>
e7e047e to
de339fd
Compare
de339fd to
c550c0d
Compare
1 participant
b/531833340