Skip to content

chore: migrate google-cloud-translate to librarian#8639

Open
jskeet wants to merge 1 commit into
googleapis:mainfrom
jskeet:migrate-translate
Open

chore: migrate google-cloud-translate to librarian#8639
jskeet wants to merge 1 commit into
googleapis:mainfrom
jskeet:migrate-translate

Conversation

@jskeet

@jskeet jskeet commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@jskeet jskeet requested a review from a team as a code owner June 15, 2026 07:55

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the configuration for the translate library. Specifically, it modifies librarian.yaml to replace skip_generate: true with a list of files to keep, deletes an unused configuration file, and updates the repository metadata in .repo-metadata.json by adding an API description, removing the billing requirement and codeowner team fields, and reformatting the JSON. There are no review comments, so I have no feedback to provide.

@jskeet

jskeet commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

Note that this has a keep list with three entries:

  • src/v2/index.ts is preserved as the v2 client
  • test/index.ts is preserved as a handwritten test for the v2 client
  • src/index.ts is preserved as there is no way currently of generating it in combine-libraries; we want to effectively have a default version of v2, but that isn't a GAPIC client. In the BazelBot/OwlBot pipeline, this is implemented by skipping the file in https://github.com/googleapis/googleapis/blob/master/google/cloud/translate/BUILD.bazel:
nodejs_gapic_combined_pkg(
    name = "google-cloud-translate-nodejs",
    default_version = "v3",
    release_level = "stable",
    templates_excludes = ["package.json", "src/index.ts", ".OwlBot.yaml"],
    deps = [
        "//google/cloud/translate/v3:translation-v3-nodejs",
        "//google/cloud/translate/v3beta1:translation-v3beta1-nodejs"
    ],
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant