feat: regenerate google-cloud-monitoring#8640
Conversation
|
This is another case (that I'd missed before) where the OwlBot configuration refers to a non-existent path in googleapis-gen. The first commit fixes the config, the second runs OwlBot locally. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the google-cloud-monitoring package, transitioning its status from stable to preview, renaming references from "Stackdriver Monitoring" to "Cloud Monitoring API", and applying extensive code formatting updates across several TypeScript files. Additionally, the protobuf definitions are updated with reserved fields. A critical issue was identified in .OwlBot.yaml where the destination path in deep-copy-regex was incorrectly changed to /owl-bot-staging/google-monitoring instead of /owl-bot-staging/google-cloud-monitoring, which leads to broken links in the auto-generated README.md.
|
tbh I think this is a misconfiguration on the internal side that put stuff in the wrong place, but it's out of scope for this PR to fix it. |
feywind
left a comment
feywind
left a comment
There was a problem hiding this comment.
I feel pretty good about most of these changes, because it looks like mostly formatting stuff. There are a couple that may need some looking at, though, like the README changes. Those might be some kind of template fail.
|
|
||
| | Sample | Source Code | | ||
| | --------------------------- | --------------------------------- | | ||
| | create alert policy | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-monitoring/samples/generated/v3/alert_policy_service.create_alert_policy.js) | |
There was a problem hiding this comment.
It looks like the "open in cloud shell" links are missing now, and I'm guessing that wasn't on purpose?
|
|
||
| See [LICENSE](https://github.com/googleapis/google-cloud-node/blob/main/LICENSE) | ||
|
|
||
| [client-docs]: https://cloud.google.com/nodejs/docs/reference/monitoring/latest |
There was a problem hiding this comment.
I'm guessing these are also still supposed to be here, unless the links are just wrong.
| deep-copy-regex: | ||
| - source: /google/monitoring/google-cloud-monitoring-nodejs | ||
| dest: /owl-bot-staging/google-cloud-monitoring | ||
| begin-after-commit-hash: ed3195d0a29ae8c2608dc5a2aa2590554a3f9d14 |
There was a problem hiding this comment.
I'm not sure I've ever seen begin-after-commit-hash so I just want to make sure this one was on purpose.
2 participants
No description provided.