feat(Spanner): Client built-in metrics - #9055
Merged
Merged
Conversation
Hectorhammett
force-pushed
the
builtin-metrics
branch
from
March 30, 2026 21:50
e2592f7 to
122f5fa
Compare
Hectorhammett
marked this pull request as ready for review
April 10, 2026 22:48
Hectorhammett
added
the
do not merge
shylene40
approved these changes
Apr 13, 2026
Hectorhammett
force-pushed
the
builtin-metrics
branch
from
May 5, 2026 18:57
d18bcfe to
14c50ad
Compare
Hectorhammett
force-pushed
the
builtin-metrics
branch
from
May 25, 2026 20:50
14c50ad to
7b74384
Compare
Hectorhammett
removed
the
do not merge
Hectorhammett
added
next release
bshaffer
reviewed
Jun 2, 2026
Hectorhammett
force-pushed
the
builtin-metrics
branch
from
June 2, 2026 21:21
72e1e47 to
c514ae9
Compare
Hectorhammett
removed
the
do not merge
…nce id is detected:
bshaffer
reviewed
Jun 8, 2026
| } | ||
| } | ||
|
|
||
| if (!$metricsClient instanceof MetricServiceClient) { |
Contributor
There was a problem hiding this comment.
NOTE: This could be updated to use an interface once we merge and release googleapis/gapic-generator-php#818
bshaffer
approved these changes
Jun 9, 2026
bshaffer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Client built in metrics for Spanner.
b/406082122