fix(storage): restore error handler in StreamWrapperTest - #9489
Open
Hectorhammett wants to merge 1 commit into
Open
fix(storage): restore error handler in StreamWrapperTest#9489Hectorhammett wants to merge 1 commit into
Hectorhammett wants to merge 1 commit into
Conversation
product-auto-label
Bot
added
the
api: storage
aandreassa
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on migrating the Auth library into the mono repo, there was a failing test related to the sysv cache tests. In Auth under the Cache folder we are using the
@directive:Link in repo
which suppresses all warnings.
While running the
StreamWrapperTesttests, Storage sets an error handler that it is never removed. Now that auth is being migrated into the mono repo this caused some errors in our migration.Edit:
Here is an error that is being fixed by this change:
https://github.com/googleapis/google-cloud-php/actions/runs/31647611005/job/94284698982
That error handling is turning a warning into an exception.