Conversation
The generic default on the internal BottomSheetModal type alias was accidentally changed from `T = any` to `T = never` in cfbe558 ("chore: updated biome and formatted the code", released in 5.2.9). That commit removed the biome-ignore comments suppressing noExplicitAny on this type, and the default was switched to `never` to satisfy the now-unsuppressed lint rule instead of restoring the ignore comment. Since this type alias is not exported from the package's public entry point, referencing it bare (e.g. `useRef<BottomSheetModal>(null)`, as shown in the docs) now resolves to `BottomSheetModalMethods<never>` instead of `BottomSheetModalMethods<any>`, which no longer satisfies the `Ref<BottomSheetModalMethods<any>>` required by JSX usage without an explicit generic. This breaks the documented usage pattern under strict TypeScript. This restores the pre-5.2.9 behavior.
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The generic default on the internal
BottomSheetModaltype alias was accidentally changed fromT = anytoT = neverin cfbe558 ("chore: updated biome and formatted the code", released in 5.2.9). That commit removed thebiome-ignorecomments suppressingnoExplicitAny, and the default was switched toneverto satisfy the lint rule instead of restoring the ignore.Since this type isn't exported from the package's public entry point, the documented bare-ref pattern (
useRef<BottomSheetModal>(null)) now resolves toBottomSheetModalMethods<never>instead of<any>, breaking under strict TypeScript.Test plan
yarn typescriptpassesyarn lintpasses (no new warnings vs master)strict: true