Conversation
|
@duckki is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
{ ... @defer { nullable required } }With
nullable: Stringandrequired: String!, letnullablethrowError("nullable failed"), then letrequiredreturnnull. Both fields execute, and both raise an execution error. The deferred completion currently contains only the error at["required"]; the error already collected at["nullable"]disappears.The same loss occurs for a streamed non-null object item:
{ users @stream(initialCount: 0) { nullable required } }With
users: [User!]and the same field behavior onUser, the stream's failed completion reports only["users", 0, "required"]and drops["users", 0, "nullable"].executeExecutionGroupandcompleteStreamItemabort and rethrow the escaping non-null error. The publisher then constructs an error list from that single thrown value, losing the executor'scollectedErrors. This also affects the legacy response format.Relevant sections of the incremental-delivery draft, pinned to
045e193:These tests concern an error that has already been raised and collected. They do not require execution of siblings that may be cancelled after a non-null failure. The draft's failure-mapping algorithm uses a singular error; preserving the collected list here is the proposed treatment of that transport boundary.
Proposed solution
IncrementalExecutionErrorthrough the existing task and stream rejection paths.AggregateErrorobjects are not flattened.The first commit observes the existing loss with passing tests. The second commit implements the fix and corrects those expectations to retain both error paths. Each public query is validated before execution.
Verification
npm teststops at the Deno runtime check because Deno is not installed locally. The separately invoked integration suite is blocked by missing Docker.This PR is scoped separately from the deferred-group lifecycle changes in #4859. Both target
17.x.x. Their publisher edits overlap: when combined, retained group failures should useerrors.flatMap(getIncrementalErrors). The combined implementation is also checked locally.