Skip to content

Create new viewport component to replace DaffSidebarViewport - #4552

Draft
damienwebdev wants to merge 5 commits into
developfrom
refactor-sidebar-viewport
Draft

damienwebdev wants to merge 5 commits into
developfrom
refactor-sidebar-viewport

Conversation

@damienwebdev

Copy link
Copy Markdown
Member

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

Current behavior

Currently, the DaffSidebarViewportComponent uses @angular/animations and doesn't use signals. It's also rather clunky to use because it doesnt internally handle state which means you have to wire everything up yourself.

Fixes: #3528

New behavior

DaffViewportComponent uses signals, no Angular animations and can manage state internally by default.

Breaking change?

  • Yes
  • No

Additional context

@damienwebdev
damienwebdev force-pushed the refactor-sidebar-viewport branch from fbdc04b to 0ead07e Compare June 23, 2026 14:15
@xelaint
xelaint force-pushed the refactor-sidebar-viewport branch 2 times, most recently from cc86cbc to bdfcce3 Compare June 24, 2026 14:19
@xelaint

xelaint commented Jun 24, 2026 •

Copy link
Copy Markdown
Member

TO DO:

  • Outline what is in the public api.
  • Make sure stateless true / false works.

DIFFS:

  • Create new viewport
  • Deprecate sidebar-viewport
  • Remove extraneous header component from app / registrations
  • Replace sidebar viewport with viewport in all examples
  • Replace sidebar viewport with viewport in daffio

@xelaint
xelaint force-pushed the refactor-sidebar-viewport branch from 21a087b to 036f8ea Compare June 30, 2026 14:13
@xelaint xelaint added package: daff.io @daffodil/daff.io package: design @daffodil/design status: wip This PR is WIP. It should be marked as a draft. labels Jun 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: daff.io @daffodil/daff.io package: design @daffodil/design status: wip This PR is WIP. It should be marked as a draft.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor DaffSidebarViewportComponent

2 participants