feat(design): convert accordion styles from px to rem - #4704
Conversation
|
|
||
| @include daff-dark-mode($mode) { | ||
| border-top: 1px solid daff-color($neutral, 80); | ||
| border-top: thin solid daff-color($neutral, 80); |
There was a problem hiding this comment.
side-comment, do we need a linting rule for this?
There was a problem hiding this comment.
specifically for 1px -> thin for borders, or rem in general?
There was a problem hiding this comment.
1px -> thin. I was a little curious about the choice here, but I figured there was good reason for it.
There was a problem hiding this comment.
Specifically for 1px borders, thin is better because
On certain screens with specific Device Pixel Ratios (DPR) or when users zoom in/out, a 1px border can sometimes snap to 0px or become uneven across different sides of a box. Because thin gives the browser the authority to resolve the rendering engine's calculation, it handles high-density pixel snapping with fewer visual layout bugs
2 participants
PR Checklist
PR Type
Current behavior
Part of: #4684
New behavior
Breaking change?
Additional context