Conversation
Build a DRN package from line, polygon and point features. Line and polygon conductance follows from the clipped length or area per cell; points use an integrated conductance. Layer placement is delegated to build_spd. Each feature keeps its own elevation, also when several features share a cell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
nlmod.gwf.drain.drain_from_df, which builds a DRN package from line, polygon and point features, similar towel_from_dfandhfb_from_df.conductance_per_meter× the length of the line inside each cell.conductance_per_squared_meter× the area inside each cell.cond).build_spd.It is meant for fixed drains such as pipes or a pumping-station basin. For seasonal surface water,
gdf_to_seasonal_pkgremains the right choice.I have simplified this PR a lot compared with the first draft. Routing drain water to lakes (MVR) and explicit 3D cellids are left out and may follow later as separate proposals.
Related: #574 (
gdf_to_griddoes not fill thelengthcolumn); this PR does not depend on it.Supersedes #564.