document: scan all ZIP local headers for OOXML type - #162
Open
team-humaki wants to merge 1 commit into
Open
team-humaki wants to merge 1 commit into
team-humaki wants to merge 1 commit into
Conversation
XLSX/DOCX/PPTX writers do not share a ZIP entry order, so looking only at the 1st/3rd/4th local name misses files such as excelize spreadsheets. Walk every local header in the buffer instead. Fixes h2non#153
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153
msooxmlassumed a ZIP local-file order (first name is[Content_Types].xml/_rels, type from the 3rd/4th name). That fails for XLSX from excelize, Excel, and Google Sheets, which putxl/later in the archive.Walk every local file header in the inspected buffer and classify from
word/,xl/, orppt/prefixes. Plain ZIP files still do not match.