Prevent unnecessary rebuild with Rust on Windows - #146
Open
FerLuisxd wants to merge 1 commit into
Open
Conversation
…f-changed on OUT_DIR
FerLuisxd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For the rust bindings, removed the line to rerun if changed when staging the dlls on Windows, because it would mark as it needs a rerun when CMake writes Dlls to the bin directory during the build.rs execution.
This should reduce the building time drastically.
My tests went from 45s to 3s.
Scope
bindings/rust/sys/build.rs)AI Assistance
Used AI to understand what was the cause of the problem, I guided and verified the changes myself.
Validation
The app compiles faster than before and with no issues.
Also verified that modifying the source again still triggers the rerun