feat!: restore package exports so ESM uses named exports only - #945
Merged
Conversation
Point import at dist/liquid.node.mjs so Node resolves the real ESM build instead of CJS interop that faked a default export. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsonexportsso Node ESMimportresolves todist/liquid.node.mjs(named exports only) instead of CJS interop that still allowed a fake default exportimport liquidjs from 'liquidjs'under ESM; aligns with intentional removal of the default exportimport#941 (reverts the exports removal from fix: use CommonJS bundle to support default export #747)Test plan
npm pack/ install and verifyimport { Liquid } from 'liquidjs'resolves the ESM buildimport liquidjs from 'liquidjs'no longer gets a default via CJS interoprequire('liquidjs')still works via therequireexport condition