Skip to content

Remove uneeded release artifacts - #12324

Merged
mergify[bot] merged 3 commits into
haskell:masterfrom
ffaf1:release-artifacts
Sep 8, 2026
Merged

mergify[bot] merged 3 commits into
haskell:masterfrom
ffaf1:release-artifacts

Conversation

@ffaf1

@ffaf1 ffaf1 commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Closes #12179.

I tested it locally by running cabal sdist --output-directory out/ Cabal-syntax Cabal-hooks Cabal cabal-install-solver hooks-exe cabal-install and confirming it works as expected.

This cannot be backported to 3.16, we used a different release method at the time.

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

This way we will not release unneeded packages like `cabal-benchmarks`.

@ulysses4ever ulysses4ever left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d put a big NOTE above this line with a quick note and a reference to the issue. This is a critical place in otherwise boring and bloated (as usual) CI script… i initially thought about introducing a global constant to make it standout more. But maybe just a comment is fine.

@ffaf1 ffaf1 added squash+merge me Tell Mergify Bot to squash-merge and removed attention: needs-review labels Sep 6, 2026
@mergify mergify Bot added the ready and waiting Mergify is waiting out the cooldown period label Sep 6, 2026
@mergify mergify Bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Sep 8, 2026
@mergify

mergify Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-09-08 12:52 UTC · Rule: squash-merge · triggered by rule Put pull requests in the squash+merge queue
  • ✅ Checks passed · on draft merge queue: checking #12324 on master (8a284b6) #12336
  • ✅ Merged — 2026-09-08 16:30 UTC · at 9b9fe2ac49d95a05b2e09d4771376302659487d4 · squash

This pull request spent 3 hours 37 minutes 39 seconds in the queue, including 1 hour 59 minutes 14 seconds running CI.

Required conditions to merge
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • github-review-approved [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

@mergify
mergify Bot merged commit 9b9fe2a into haskell:master Sep 8, 2026
85 of 87 checks passed
@mergify mergify Bot removed the queued label Sep 8, 2026
@ffaf1

ffaf1 commented Sep 8, 2026 •

Copy link
Copy Markdown
Collaborator Author

@mergify backport 3.18

@mergify

mergify Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

backport 3.18

✅ Backports have been created

Details

mergify Bot added a commit that referenced this pull request Sep 9, 2026
Backport #12324: Remove uneeded release artifacts
Mikolaj pushed a commit to Mikolaj/cabal that referenced this pull request Sep 10, 2026
* Spell options longhand

* List source distribution file targets

This way we will not release unneeded packages like `cabal-benchmarks`.

* Add explanatory note

(cherry picked from commit 9b9fe2a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attention: needs-backport 3.18 merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days ready and waiting Mergify is waiting out the cooldown period release squash+merge me Tell Mergify Bot to squash-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unneeded release artifacs generated by release script

3 participants