Skip to content

Fixed readthedoc in errors and upgraded testlib partner to 8.4.0 in t… #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VisLab merged 1 commit into from
Jun 22, 2026
Merged

Fixed readthedoc in errors and upgraded testlib partner to 8.4.0 in t… #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/issues/issues.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ export class Issue {
*/
_generateHedSpecificationLink() {
const hedCodeAnchor = this.hedCode.toLowerCase().replace(/_/g, '-')
return `For more information on this HED ${this.level}, see https://hed-specification.readthedocs.io/en/latest/Appendix_B.html#${hedCodeAnchor}`
return `For more information on this HED ${this.level}, see https://www.hedtags.org/hed-specification/Appendix_B.html#${hedCodeAnchor}`
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/jsonTestData/schemaBuildTests.data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export const schemaBuildTestData = [
testname: 'lazy-partnered-with wrong-standard-build',
explanation: '["testlib_2.0.0", "8.3.0"] has wrong standard schema',
schemaVersion: { Name: 'BadLazyPartnered', HEDVersion: ['testlib_2.0.0', '8.3.0'] },
schemaError: new IssueError(generateIssue('differentWithStandard', { first: '8.3.0', second: '8.2.0' })),
schemaError: new IssueError(generateIssue('differentWithStandard', { first: '8.3.0', second: '8.4.0' })),
},
{
testname: 'lazy-partnered-with conflicting-tags-build',
Expand Down
2 changes: 1 addition & 1 deletion tests/otherTests/issueParameters.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ describe('Issue Parameters Tests', () => {
expectedMessageParts.forEach((part) => {
expect(message).toContain(part)
})
expect(message).toContain('https://hed-specification.readthedocs.io')
expect(message).toContain('https://www.hedtags.org/hed-specification')
expect(message).toContain('For more information on this HED error')
}

Expand Down
6 changes: 3 additions & 3 deletions tests/otherTests/schema.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ describe('HED schemas', () => {
})

it('should build schemas from comma-separated version strings', async () => {
const versionString = '8.2.0, testlib_2.0.0'
const versionString = '8.4.0, testlib_2.0.0'
const schemas = await buildSchemasFromVersion(versionString)

assert.isNotNull(schemas, 'Schemas should not be null')
Expand All @@ -367,12 +367,12 @@ describe('HED schemas', () => {
})

it('should build schemas from comma-separated version strings with spaces', async () => {
const versionString = ' 8.2.0 , testlib_2.0.0 '
const versionString = ' 8.4.0 , testlib_2.0.0 '
const schemas = await buildSchemasFromVersion(versionString)

assert.isNotNull(schemas, 'Schemas should not be null')
assert.instanceOf(schemas.baseSchema, PartneredSchema)
assert.strictEqual(schemas.baseSchema.withStandard, '8.2.0')
assert.strictEqual(schemas.baseSchema.withStandard, '8.4.0')
})

it('should build schemas from multiple partnered schemas', async () => {
Expand Down