chore: drop the leftover .npmrc - #6
Merged
Merged
Conversation
It carried node-options=--experimental-vm-modules, which jest needed to run ESM tests. The runner is vitest now and needs nothing, so the file only described a tool the repository no longer has. It was also an npm setting: pnpm does not apply node-options to scripts, so it had already stopped taking effect before this. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.npmrccarriednode-options=--experimental-vm-modules, which jest needed to run ESM tests. The runner is vitest now and needs nothing, so the file only described a tool this repository no longer has.It was doubly dead:
node-optionsis an npm setting, and pnpm does not apply it when running scripts, so it had already stopped taking effect at the pnpm migration.make testandmake lintpass without it.