fix(notifications): stop channel-closed storm when switching nodes - #735
Merged
Merged
Conversation
Switching nodes left the previous node's channel, balance and info snapshots in app.previousStates, so the first fetch for the new node was diffed against the old one and every channel the old node had was reported as closed. Restore the appActions.resetNodeState() dispatch that 0f66b70 dropped from the login modal, and clear the notification bell on switch and on logout. Also scope the snapshots to a node: previousStates now records the apiEndpoint it was taken from, and useWatcher reseeds silently instead of diffing when the connected node no longer matches, so this cannot regress unnoticed again. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching nodes left the previous node's channel, balance and info snapshots in app.previousStates, so the first fetch for the new node was diffed against the old one and every channel the old node had was reported as closed.
Restore the appActions.resetNodeState() dispatch that 0f66b70 dropped from the login modal, and clear the notification bell on switch and on logout.
Also scope the snapshots to a node: previousStates now records the apiEndpoint it was taken from, and useWatcher reseeds silently instead of diffing when the connected node no longer matches, so this cannot regress unnoticed again.