Raise on subprocesses terminated by signals - #4301
Open
Titus-von-Koeller wants to merge 4 commits into
Open
Titus-von-Koeller wants to merge 4 commits into
Titus-von-Koeller wants to merge 4 commits into
Conversation
Treat every nonzero exit status as failure. Add real-child regressions for success, ordinary failure and POSIX signal termination while preserving captured diagnostics. Co-Authored-By: Codex <noreply@openai.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Titus-von-Koeller
marked this pull request as ready for review
September 21, 2026 08:53
SunMarc
approved these changes
Sep 29, 2026
Titus-von-Koeller
force-pushed
the
fix-subprocess-signal-exits
branch
from
October 3, 2026 09:40
7087b76 to
051314e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execute_subprocess_asynctreats a signal-killed child as successful because it only raises for positive return codes. POSIX reports signal termination with a negative code. This raises for any nonzero exit status, preserving captured stderr and the existing exception type.A real-child SIGTERM regression fails before the fix and passes after it on Python 3.10. It skips on non-POSIX systems.
Related: #4304 — enforce requested timeouts and clean up interrupted launches changes the same helper. The fixes can be merged independently.