Repository navigation
Conversation
Self-review — AutoencoderKLKVAEAudioRan the self-review skill against the full Blocking issuesNone found. Non-blocking issues1. Non-contiguous tensor feeds into 2. Reuse of the generic 3. Dead code (advisory)No pipeline is introduced in this PR (standalone VAE addition), so the usual "trace from pipeline
Summary — READYNo blocking issues. Numerics were independently verified against the reference
|
|
Dear We are among a small circle of labs that develops their own VAEs and ours are truely good. |
DN6
left a comment
There was a problem hiding this comment.
LGTM. Requesting a small change to the attention module and I have a question about the sample_rate arg.
|
|
||
| from ...configuration_utils import ConfigMixin, register_to_config | ||
| from ...utils.accelerate_utils import apply_forward_hook | ||
| from ..attention_processor import Attention |
There was a problem hiding this comment.
@ivnvalex Could we just define a dedicated attention class and processor for this model please.
|
|
||
| from ...configuration_utils import ConfigMixin, register_to_config | ||
| from ...utils.accelerate_utils import apply_forward_hook | ||
| from ..attention_processor import Attention |
There was a problem hiding this comment.
@ivnvalex Could we just define a dedicated attention class and processor for this model please. Similar to
| The latent representations of the encoded audio. If `return_dict` is True, a | ||
| [`~models.autoencoder_kl.AutoencoderKLOutput`] is returned, otherwise a plain `tuple` is returned. | ||
| """ | ||
| if sample_rate is not None and sample_rate != self.config.sample_rate: |
There was a problem hiding this comment.
Is sample_rate necessary? It doesn't seem to be used anywhere beyond this raise?

What does this PR do?
Adds
KVAE-AudioasAutoencoderKLKVAEAudio, a 1D convolutional audio VAE, completing the KVAE tokenizers family from the Kandinsky Lab team in Diffusers alongside the already-mergedAutoencoderKLKVAE(image) andAutoencoderKLKVAEVideo(video).It loads the checkpoint from
kandinskylab/KVAE-Audioand compresses/reconstructs raw full-band (48 kHz) waveforms into continuous latents.We have also released a technical report: KVAE: Family of Tokenizers for Multimodal Generative Models.
Before submitting
self-reviewskill on the diff?documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@yiyixuxu, @asomoza hello guys, could you please check the PR? Thank you!