Repository navigation
Conversation
Rename deinitalize_hook to deinitialize_hook and keep the old spelling as an alias so existing callers and subclasses still work.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename the misspelled
ModelHook.deinitalize_hooktodeinitialize_hook, matchinginitialize_hookand the existing “deinitialized” docstring wording, while keeping the old name as a compatibility alias.Changes
src/diffusers/hooks/hooks.py: adddeinitialize_hook; keepdeinitalize_hookas an alias;HookRegistry.remove_hookcalls the corrected namesrc/diffusers/hooks/layerwise_casting.py/sea_cache.py: overridedeinitialize_hook__init_subclass__mirrors either spelling onto the other so third-party subclasses that only define the old name still worktests/hooks/test_hooks.py: coverage for the rename/alias behaviorNotes
No
FutureWarningon the alias (keeps the diff quiet). This is not covered by the open codespell PR #13842.