Repository navigation
Conversation
Signed-off-by: Subodh Bansode <subodh171011@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14901.
numpy_to_pilincorrectly uses an unrestrictedsqueeze()for grayscale images. When a valid spatial dimension has size 1, that dimension is removed together with the singleton channel dimension.For example, an image with shape
(1, 7, 1)is converted incorrectly because both singleton spatial/channel dimensions are squeezed.This PR makes the squeeze operation explicit so that only the intended channel dimension is removed.
What changed?
squeeze(-1)for HWC grayscale image paths.squeeze(0)for CHW grayscale image paths.Affected production files:
src/diffusers/utils/pil_utils.pysrc/diffusers/image_processor.pyexamples/dreambooth/train_dreambooth_lora_flux2_img2img.pyexamples/dreambooth/train_dreambooth_lora_flux2_klein_img2img.pyRegression test:
(1, 7, 1)->(7, 1)(7, 1, 1)->(1, 7)(1, 1, 1)->(1, 1)Tests
pytest tests/others/test_image_processor.pyResult:
11 passed, 2 warnings.
Also verified normal RGB inputs remain unaffected.
The commit is DCO signed.