Repository navigation
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
github-actions
Bot
added
size/L
DN6
reviewed
Oct 9, 2026
| grad_query, grad_key, grad_value = torch.empty_like(query), torch.empty_like(key), torch.empty_like(value) | ||
|
|
||
| _ = wrapped_backward_fn( | ||
| grad_out, query, key, value, out = ( |
Collaborator
There was a problem hiding this comment.
I think the grad_* tensors would need to be contiguous as well right?
github-actions
Bot
added
size/M
Author
|
note this pr is a work in progress - and may require some small changes upstream to the flash attn2 to improve the exposure of public apis. will add updates here as this work progresses |
drbh
force-pushed
the
prefer-public-attention-apis
branch
from
October 13, 2026 21:12
cc4003b to
e463787
Compare
github-actions
Bot
added
size/S
drbh
changed the title
Author
|
this pr has changed to simply bump the version to the latest (future) version of fa2, relevant pr here huggingface/kernels-community#1226 once the new version is published, no changes should be needed on the diffuser side as the apis needed have been promoted to be public/available |
drbh
force-pushed
the
prefer-public-attention-apis
branch
from
October 14, 2026 16:09
0afaa6d to
e860001
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr update the attention dispatch to avoid using private flash attention apis that have been removed in all hub flash attention versions >1