Repository navigation
Update FlashAttention Hub integration and guard CUDA-only tests - #15024
Conversation
Signed-off-by: Wang, Yi <yi.a.wang@intel.com>
|
@sayakpaul please help review, verified in A100 |
| softcap, | ||
| alibi_slopes, | ||
| return_lse, | ||
| False, |
There was a problem hiding this comment.
So this means return_softmax is always False?
There was a problem hiding this comment.
see https://huggingface.co/kernels/kernels-community/flash-attn2/blob/v3/build/torch-stable-abi210-cu132-x86_64-linux/flash_attn_interface.py#L142, return_softmax will impact the third output(dmask) which is not used in the code.
There was a problem hiding this comment.
My question is what parameter does that False value correspond to? Is it not return_softmax?
There was a problem hiding this comment.
it's return_softmax in v3, and default is False
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Hi @sywangyi, thanks for the PR! It does not appear to link an issue it fixes. If this PR addresses an existing issue, please add a closing keyword (e.g. Please note that PRs without a linked issue are likely to be automatically closed 10 days after this notice. Once the PR links an issue (or gets the |
version=1 only has <=torch2.12 support and in v3, return_lse is not the input arg(https://huggingface.co/kernels/kernels-community/flash-attn2/blob/v3/build/torch-stable-abi210-cu132-x86_64-linux/flash_attn_interface.py#L164) and do not support dropout>0