Skip to content

(feat) Add bing_x bulk ticker source for /market-data/tickers - #231

Open
aMoonshine wants to merge 1 commit into
hummingbot:mainfrom
aMoonshine:feat/bingx-bulk-ticker
Open

(feat) Add bing_x bulk ticker source for /market-data/tickers#231
aMoonshine wants to merge 1 commit into
hummingbot:mainfrom
aMoonshine:feat/bingx-bulk-ticker

Conversation

@aMoonshine

Copy link
Copy Markdown

Summary

Adds a bulk TickerSpec for the bing_x connector so GET /market-data/tickers?connectors=bing_x works with a single request instead of reporting "No ticker data" for BingX.

  • Endpoint: GET /openApi/spot/v1/ticker/24hr (BingX spot REST, base https://open-api.bingx.com; the /openapi prefix is rejected by BingX for spot market endpoints with error 100400)
  • Mapping: rows under data; symbol → symbol, bidPrice → bid, askPrice → ask, lastPrice → last, volume → base volume, quoteVolume → quote volume
  • Adds a deterministic unit test (test_bing_x_bulk_ticker_request_and_mapping) using a fake connector that asserts the request path and the price/volume field mapping

Testing

  • Focused: pytest test/test_ticker_sources.py::test_bing_x_bulk_ticker_request_and_mapping — passes
  • Live verification against BingX prod: GET /market-data/tickers?connectors=bing_x&refresh=true returns 691 trading pairs with errors: {}

BingX spot exposes 24h tickers via GET /openApi/spot/v1/ticker/24hr
(base https://open-api.bingx.com). Register a TickerSpec so
GET /market-data/tickers?connectors=bing_x performs one bulk request
instead of failing with "No ticker data".

Mapping: rows under "data"; symbol=symbol, bid=bidPrice, ask=askPrice,
last=lastPrice, base_volume=volume, quote_volume=quoteVolume.

Adds a deterministic unit test (fake connector) asserting request path
and price/volume mapping. Live-verified: 691 pairs returned, errors {}.
@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown

Greptile Summary

The PR adds bulk BingX spot ticker support to the shared ticker-source registry and verifies its request and normalization behavior.

  • Registers the BingX 24-hour ticker endpoint and maps its price and volume fields.
  • Adds an asynchronous unit test covering the request path and normalized ticker values.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or compatibility issues identified.

The added ticker specification follows the existing request and normalization contracts, while the focused test and reported live verification cover the principal endpoint, symbol, price, and volume integration paths.

Important Files Changed

Filename Overview
services/ticker_sources.py Adds a BingX bulk ticker specification consistent with the existing normalization framework, with no actionable defect identified.
test/test_ticker_sources.py Adds deterministic coverage for the BingX request path and price/volume mapping using a focused fake connector.

Reviews (1): Last reviewed commit: "(feat) add bing_x bulk ticker source for..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant