(feat) Add bing_x bulk ticker source for /market-data/tickers - #231
Open
aMoonshine wants to merge 1 commit into
Open
(feat) Add bing_x bulk ticker source for /market-data/tickers#231aMoonshine wants to merge 1 commit into
aMoonshine wants to merge 1 commit into
Conversation
BingX spot exposes 24h tickers via GET /openApi/spot/v1/ticker/24hr (base https://open-api.bingx.com). Register a TickerSpec so GET /market-data/tickers?connectors=bing_x performs one bulk request instead of failing with "No ticker data". Mapping: rows under "data"; symbol=symbol, bid=bidPrice, ask=askPrice, last=lastPrice, base_volume=volume, quote_volume=quoteVolume. Adds a deterministic unit test (fake connector) asserting request path and price/volume mapping. Live-verified: 691 pairs returned, errors {}.
Greptile SummaryThe PR adds bulk BingX spot ticker support to the shared ticker-source registry and verifies its request and normalization behavior.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, security, or compatibility issues identified. The added ticker specification follows the existing request and normalization contracts, while the focused test and reported live verification cover the principal endpoint, symbol, price, and volume integration paths.
|
| Filename | Overview |
|---|---|
| services/ticker_sources.py | Adds a BingX bulk ticker specification consistent with the existing normalization framework, with no actionable defect identified. |
| test/test_ticker_sources.py | Adds deterministic coverage for the BingX request path and price/volume mapping using a focused fake connector. |
Reviews (1): Last reviewed commit: "(feat) add bing_x bulk ticker source for..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a bulk
TickerSpecfor thebing_xconnector soGET /market-data/tickers?connectors=bing_xworks with a single request instead of reporting "No ticker data" for BingX.GET /openApi/spot/v1/ticker/24hr(BingX spot REST, basehttps://open-api.bingx.com; the/openapiprefix is rejected by BingX for spot market endpoints with error 100400)data;symbol→ symbol,bidPrice→ bid,askPrice→ ask,lastPrice→ last,volume→ base volume,quoteVolume→ quote volumetest_bing_x_bulk_ticker_request_and_mapping) using a fake connector that asserts the request path and the price/volume field mappingTesting
pytest test/test_ticker_sources.py::test_bing_x_bulk_ticker_request_and_mapping— passesGET /market-data/tickers?connectors=bing_x&refresh=truereturns 691 trading pairs witherrors: {}