fix: expose market data provider to executors - #232
Open
matvt-cell wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion change for hummingbot/hummingbot#8453 and hummingbot/hummingbot#8437.
Hummingbot API already uses
MarketDataServiceas its pricing source, but executor strategies did not expose that service through themarket_data_providerinterface expected by the core GridExecutor fee-conversion path.This change exposes the existing
MarketDataServicefromAccountTradingInterfaceasmarket_data_provider.That allows GridExecutor in hummingbot/hummingbot#8453 to resolve third-token fees such as BNB -> USDT through the API market-data pricing pool instead of relying exclusively on the legacy RateOracle singleton.
Changes
AccountTradingInterface.market_data_provider_market_data_serviceTests
python -m pytest test/test_account_trading_interface.py -q1 passed
Dependency
Depends on hummingbot/hummingbot#8453
Related to hummingbot/hummingbot#8437