fix(rn): allow react-native-nitro-modules >=0.36.5 - #475
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe package metadata changes the ChangesPeer dependency update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yarn.lock records the peer range too, so widening it in package.json alone left `yarn install --immutable` refusing to run. That is one job by name, but every other react-native job installs first, which is why ten checks failed on one edit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
=======================================
Coverage 76.42% 76.42%
=======================================
Files 157 157
Lines 16714 16714
Branches 4814 4814
=======================================
Hits 12773 12773
Misses 3941 3941
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The manifest and lockfile changes are consistent, scoped, and correctly remove the restrictive upper bound.
Review effort: Balanced
Findings: None
What changed in this PR
Expands React Native IAP compatibility with Nitro Modules 0.37+ while retaining 0.36.5 as the minimum.
Changes:
- Updates the peer dependency to
>=0.36.5. - Synchronizes the Yarn lockfile metadata.
| File | Description |
|---|---|
libraries/react-native-iap/package.json |
Broadens the Nitro Modules peer range. |
libraries/react-native-iap/yarn.lock |
Reflects the updated peer requirement. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
hyochan
left a comment
There was a problem hiding this comment.
Verified that Nitro 0.37.1 resolves without peer overrides, the minimum version remains enforced, and package metadata matches the lockfile. The complete head review and CI are clean.
|
Shipped in react-native-iap 16.6.2 🚀 |
Allow apps using
react-native-nitro-modules0.37.1 to install without a peer-dependency conflict. The peer range becomes>=0.36.5, and the Yarn workspace lock entry matches it. Development dependencies and Nitrogen code generation keep their existing pins.Verified with local package tarballs and npm's dependency resolver: the existing range fails with
ERESOLVEagainst Nitro 0.37.1, while this PR resolves successfully without overrides or--legacy-peer-deps. The minimum-version boundary and manifest/lockfile consistency checks pass. The contributor also reports iOS and Android release builds with Nitro 0.37.1.CodeRabbit reviewed the manifest change; a separate read-only Codex review of 8822cc1, including the lockfile update, found no issues.
Preview: no visual surface; the npm dependency-resolution check reproduces and verifies the fix.