Skip to content

fix(rn): allow react-native-nitro-modules >=0.36.5 - #475

Merged
hyochan merged 2 commits into
hyodotdev:mainfrom
jslok:fix/rn-iap-nitro-peer-range
Sep 19, 2026
Merged

hyochan merged 2 commits into
hyodotdev:mainfrom
jslok:fix/rn-iap-nitro-peer-range

Conversation

@jslok

@jslok jslok commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Allow apps using react-native-nitro-modules 0.37.1 to install without a peer-dependency conflict. The peer range becomes >=0.36.5, and the Yarn workspace lock entry matches it. Development dependencies and Nitrogen code generation keep their existing pins.

Verified with local package tarballs and npm's dependency resolver: the existing range fails with ERESOLVE against Nitro 0.37.1, while this PR resolves successfully without overrides or --legacy-peer-deps. The minimum-version boundary and manifest/lockfile consistency checks pass. The contributor also reports iOS and Android release builds with Nitro 0.37.1.

CodeRabbit reviewed the manifest change; a separate read-only Codex review of 8822cc1, including the lockfile update, found no issues.

Preview: no visual surface; the npm dependency-resolution check reproduces and verifies the fix.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 5d5ecbd5-eb03-4a99-a7ec-8bd3b6ecb000

📥 Commits

Reviewing files that changed from the base of the PR and between 9aa55ba and 74d2aca.

📒 Files selected for processing (1)
  • libraries/react-native-iap/package.json

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The package metadata changes the react-native-nitro-modules peer dependency from ^0.36.5 to >=0.36.5.

Changes

Peer dependency update

Layer / File(s) Summary
Peer dependency range
libraries/react-native-iap/package.json
The accepted react-native-nitro-modules peer dependency range changes from ^0.36.5 to >=0.36.5.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: hyochan

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: allowing react-native-nitro-modules versions 0.36.5 and newer.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

yarn.lock records the peer range too, so widening it in package.json alone
left `yarn install --immutable` refusing to run. That is one job by name, but
every other react-native job installs first, which is why ten checks failed on
one edit.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@hyochan hyochan added 🛠 bugfix All kinds of bug fixes react-native-iap react-native-iap library 📦 update packages labels Sep 19, 2026
@codecov

codecov Bot commented Sep 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.42%. Comparing base (78a6a91) to head (8822cc1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   76.42%   76.42%           
=======================================
  Files         157      157           
  Lines       16714    16714           
  Branches     4814     4814           
=======================================
  Hits        12773    12773           
  Misses       3941     3941           
Flag Coverage Δ
react-native-iap 93.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
React Native IAP 93.11% <ø> (ø)
Expo IAP 90.51% <ø> (ø)
flutter_inapp_purchase 90.42% <ø> (ø)
IAPKit Server 92.03% <ø> (ø)
IAPKit Convex 61.97% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The manifest and lockfile changes are consistent, scoped, and correctly remove the restrictive upper bound.

Review effort: Balanced
Findings: None

What changed in this PR

Expands React Native IAP compatibility with Nitro Modules 0.37+ while retaining 0.36.5 as the minimum.

Changes:

  • Updates the peer dependency to >=0.36.5.
  • Synchronizes the Yarn lockfile metadata.
File Description
libraries/​react-native-iap/​package.json Broadens the Nitro Modules peer range.
libraries/​react-native-iap/​yarn.lock Reflects the updated peer requirement.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@hyochan hyochan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that Nitro 0.37.1 resolves without peer overrides, the minimum version remains enforced, and package metadata matches the lockfile. The complete head review and CI are clean.

@hyochan
hyochan merged commit e20e0d4 into hyodotdev:main Sep 19, 2026
54 checks passed
@hyochan

hyochan commented Sep 19, 2026

Copy link
Copy Markdown
Member

Shipped in react-native-iap 16.6.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🛠 bugfix All kinds of bug fixes react-native-iap react-native-iap library 📦 update packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants