fix(fswatcher): Use a time.NewTicker channel for file re-syncs - #251
Merged
onelapahead merged 3 commits intoSep 9, 2026
Merged
Conversation
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
peterbroadhurst
left a comment
peterbroadhurst
left a comment
Contributor
There was a problem hiding this comment.
Very clear change 👍
onelapahead
enabled auto-merge
September 8, 2026 21:13
Signed-off-by: hfuss <hayden.fuss@kaleido.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We observed in some environments, bc
fswatchercan only watch a dir (and then filter by file), if there constantly changes to the dir (regardless of whether thats intended or a separate 🐛 ) - it prevents the re-sync from firing because we used atime.Afterin thefor, meaning we reset it on every loop.Using a
time.NewTickerwe get a channel that will add an event to the channel on the configured interval, so that no matter what the select will eventually hit the re-sync regardless of how many FS events we get, so we still re-sync eventually to make reconciliation reliable.