Fixed a bug in the Appleton-Bray model - #177
Open
sanjeev1407 wants to merge 2 commits into
Open
sanjeev1407 wants to merge 2 commits into
sanjeev1407 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sigma expression for the electron-ion collision in the Appletron-Bray model was originally derived in CGS-ESU units in the 1964 Appleton-Bray paper. However, the same expression has been used in hy2Foam assuming SI units, which is inconsistent. To convert the charge of electron from esu to Coulumb, we need to multiply an extra (1/4piepsilon0) term and hence the final expression of sigma would change.
This has been fixed in this commit and now gives correct results for the FIRE II testcase where the Omega_HE term is dominant.