Rebase onto dev - #22
Open
i8degrees wants to merge 534 commits into
Open
Conversation
These are the absolute minimum required changes to get nomlib
to build on my Xubuntu 14.04.1 LTS box. Unit tests pass and
examples work.
TODO
- [ ] Publish linux build notes in nomlib's README.md
- [ ] Implement stubbed functions in UnixFile.
- [ ] VisualUnitTest timestamp sync bug; this bug results in multiple
directories being created per screen dump.
No linking stage just yet, but soon.
* Value: Remove assertion check in ::empty && ::clear * Value: Remove template function ::get_value. * ValueIteratorBase: Remove key_v2 method (never used). * Value: Remove commented out ::at function. * Value: Change return type of Value::size to nom::size_type (from nom::uint). * Value: Clean up readability of lesser than handling operator overload logic. * Value: Clean up readability of equality handling operator overload logic. * Value: Finish out initialization code for non-object value types -- null through boolean types -- when the enumeration ctor is used for creation. * VString: Change ArrayIndex integral type to nom::size_type (from nom::uint).
No linking stage just yet, but soon.
[ai] Remove per-library export header generation and update install paths
This allows us to manually set breakpoints for use with debuggers (i.e., `gdb`).
- `include/nomlib/macros.hpp` - Wrap deletion macros in braces to ensure pointer is set to nullptr
-Wshadow (Rect && File) - const (senseless) - color escape codes (invalid ASCII) - remove NOM_DEBUG requirement for use of compiler specific features -- see NOM_IGNORED_VARS macros - fix NOM_ASSERT macro when NDEBUG is defined (config.hpp.in)
Remove vcpkg env section from top-level project; this is too difficult to maintain and has been relocated back to `CMakePresets.json`. Replace several resource dir variables; - `NOMLIB_RESOURCES_DIR` - `NOMLIB_SHARED_SUPPORT_DIR` - `NOM_EXAMPLES_RESOURCES_DIR` with built-in cmake vars in hopes this improves readability & long-term maintenance. The `CmakePresets.json` is completely revamped with several new hidden presets that are inherited from depending on the name and OS. The three big ones are: vcpkg, clang and xcode. Remove cmake functions `install_resource_file` && `install_resource_dir`. Remove the branches guarded with USE_OLD_OSX_CODE, USE_OLD_WIN_CODE, USE_OLD_OSX_CODE. Hurray! Ensure that a Python3 interpretor and GNU Patch are available to the vendor build system at configure time. This was done to aid the vcpkg port of nomlib.
Ensure that examples that are console based are not built with WinMAIN, but SDL2main. Fix missing standard types Ensure that even when our SDL2_TTF version check bits fail -- see `src/CMakeLists.txt` -- that we have a safe default (assume latest SDL2_TTF).
This resolves all but one remaining issue with the examples on MacOS. The final remaining issue now is dealing with the copying of the resource data files into its right place.
This resolves the console executable trying to setup graphics rendering, which can fail if the video driver does not support OpenGL. This is a console I/O executable.
One typedef file to modify instead of several.
(I have yet to modify the game.cpp to reflect the changes)
Remove vcpkg env section from top-level project; this is too difficult to maintain and has been relocated back to `CMakePresets.json`. Replace several resource dir variables; - `NOMLIB_RESOURCES_DIR` - `NOMLIB_SHARED_SUPPORT_DIR` - `NOM_EXAMPLES_RESOURCES_DIR` with built-in cmake vars in hopes this improves readability & long-term maintenance. The `CmakePresets.json` is completely revamped with several new hidden presets that are inherited from depending on the name and OS. The three big ones are: vcpkg, clang and xcode. Remove cmake functions `install_resource_file` && `install_resource_dir`. Remove the branches guarded with USE_OLD_OSX_CODE, USE_OLD_WIN_CODE, USE_OLD_OSX_CODE. Hurray! Ensure that a Python3 interpretor and GNU Patch are available to the vendor build system at configure time. This was done to aid the vcpkg port of nomlib.
- Do not use WIN32 exe flag on console apps * Ensure that SDL2main is available to link - Add POST_BUILD step to copy resource files to target exe dir at post- build cycle. Remove cmake install commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review and merge