Assert changed translations too, not just added/deleted#32
Draft
mikadamczyk wants to merge 1 commit into
Draft
Conversation
Depends on jms-translation-bundle's new ChangeSet::getChangedMessages(). Assertion logic extracted into a static method so it's unit-testable without booting a kernel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbstractTranslationCase only failed on added/deleted messages, so a stale desc/meaning never failed the test. Now it also fails on changed messages, using the new ChangeSet::getChangedMessages() API. Assertion logic pulled into a static method so it's unit-testable without a kernel.
Depends on ibexa/jms-translation-bundle#5 (not merged/released yet), so CI here will be red until that lands. Draft for that reason.