Skip to content

fix: keep dialogs scrollable within viewport #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vthwang merged 1 commit into from
Sep 23, 2026
+8 −8
Merged

fix: keep dialogs scrollable within viewport #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/ui/dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function DialogContent({
<DialogPrimitive.Content
data-slot="dialog-content"
className={cn(
"fixed top-1/2 left-1/2 z-50 grid w-full max-w-[calc(100%-2rem)] -translate-x-1/2 -translate-y-1/2 gap-4 rounded-xl bg-popover p-4 text-sm text-popover-foreground ring-1 ring-foreground/10 duration-100 outline-none sm:max-w-sm data-open:animate-in data-open:fade-in-0 data-open:zoom-in-95 data-closed:animate-out data-closed:fade-out-0 data-closed:zoom-out-95",
"fixed top-1/2 left-1/2 z-50 grid max-h-[calc(100dvh-2rem)] w-full max-w-[calc(100%-2rem)] -translate-x-1/2 -translate-y-1/2 gap-4 overflow-y-auto rounded-xl bg-popover p-4 text-sm text-popover-foreground ring-1 ring-foreground/10 duration-100 outline-none sm:max-w-sm data-open:animate-in data-open:fade-in-0 data-open:zoom-in-95 data-closed:animate-out data-closed:fade-out-0 data-closed:zoom-out-95",
className
)}
{...props}
Expand Down
12 changes: 6 additions & 6 deletions src/pages/admin/UpgradeModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,11 +233,11 @@ export function UpgradeModal({ selection, defaultComponents = ['vta'], batchId:
</div>
)}
{preview.skipped.length > 0 && (
<div>
<p style={{ margin: '0 0 6px', fontSize: 12, fontWeight: 600, color: 'hsl(var(--foreground))' }}>
Skipped
</p>
<div style={{ display: 'flex', flexDirection: 'column', gap: 6, color: 'hsl(var(--muted-foreground))' }}>
<details>
<summary style={{ fontSize: 12, fontWeight: 600, color: 'hsl(var(--foreground))', cursor: 'pointer' }}>
Skipped ({preview.skipped.length})
</summary>
<div style={{ display: 'flex', flexDirection: 'column', gap: 6, marginTop: 6, color: 'hsl(var(--muted-foreground))' }}>
{preview.skipped.map((s, i) => (
<div key={i} style={{
display: 'grid',
Expand All @@ -258,7 +258,7 @@ export function UpgradeModal({ selection, defaultComponents = ['vta'], batchId:
</div>
))}
</div>
</div>
</details>
)}
</div>
)}
Expand Down
2 changes: 1 addition & 1 deletion src/styles/portal.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@

/* --- Dialog overlay --- */
.portal-root .p-overlay { position: fixed; inset: 0; background: hsl(0 0% 0% / 0.5); backdrop-filter: blur(2px); display: grid; place-items: center; padding: 24px; z-index: 100; }
.portal-root .p-dialog { width: 100%; max-width: 460px; background: hsl(var(--popover)); color: hsl(var(--popover-foreground)); border: 1px solid hsl(var(--border)); border-radius: var(--radius); box-shadow: var(--shadow-lg); overflow: hidden; }
.portal-root .p-dialog { width: 100%; max-width: 460px; max-height: calc(100dvh - 48px); background: hsl(var(--popover)); color: hsl(var(--popover-foreground)); border: 1px solid hsl(var(--border)); border-radius: var(--radius); box-shadow: var(--shadow-lg); overflow-x: hidden; overflow-y: auto; }
/* The gap below the header lives on the header, not on the body's top: a
confirm dialog with no body would otherwise sit its description straight on
the footer. Totals are unchanged for dialogs that do have a body. */
Expand Down
Loading