build(windows): Port generate.sh script to Windows - #109
Open
indyteo wants to merge 1 commit into
Open
Conversation
Contributor
|
Je vois cette PR prendre la poussière... faut qu'on s'installe un Windows pour tester :'( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of modification
generatehelper scriptChanges
This PR adds Windows version of the helper script.
Feature description
I rewrote the
generate.shshell script in batch (generate.bat) and PowerShell (generate.ps1) to allow Windows users to use it.I also updated the messages of the original script because I noticed some minor issues.
Finally, I updated the docs to reflect those changes.
Showcase
Batch help example
PowerShell help example
Note: Since the help message is partially auto-generated, some parts are in my computer's language (French)Reason
Since commit 63e5169, Windows users cannot really use the bundled example files to start the generator anymore. The solution I came up with was just to rewrite the shell script in batch, then I realized how terrible batch was, thus I did it in PowerShell as well.
Another solution would be to rewrite that helper script in a platform-independent language, such as Java (using Maven modules could allow us to keep the main generator apart from that helper tool, for example). This would require a little bit more work initially, but maybe a bit less later.
Self-checks
The code has unit tests associatedThe code has Javadoc Comments associated/docsfolder has been updatedAll examples indocs/usage/Examples.mdwork the same (or have been adapted if subject to changes in this PR)