Skip to content

fix(examples): now water and glaciers are distinguished #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
naulan-chrzaszcz wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(examples): now water and glaciers are distinguished #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/formats/minecraft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
format: minecraft
references:
- &voxel-stone minecraft:stone
- &voxel-snowfields minecraft:snow_block

@indyteo indyteo May 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu utilises ça pour représenter les glaciers, ça me semble un peu étrange de choisir de la neige (et d'appeler ça "snowfields").
Certes les névés sont des amas de neige, mais qui a durci, et vu qu'on n'a pas de moyen de différencier les deux, je dirais que la neige dure s'apparente plus facilement à de la glace que le contraire... Quelque chose comme de la Packed Ice devrait faire l'affaire.
D'autant plus que pour les générations en montagne, on pourra activer le mode neige pour ajouter une couche de neige partout, si on veut (d'où le fait de se concentrer ici à mon sens sur les glaciers)

- &voxel-dirt minecraft:dirt
- &voxel-cobble minecraft:cobblestone
- &voxel-empty minecraft:air
Expand Down
1 change: 1 addition & 0 deletions examples/formats/minetest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
format: minetest
references:
- &voxel-stone default:stone
- &voxel-snowfields default:snowblock
- &voxel-dirt default:dirt
- &voxel-cobble default:cobble
- &voxel-empty default:air
Expand Down
10 changes: 10 additions & 0 deletions examples/places/meije.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# La Meije is a mountain in the Massif des Écrins range.
worldName: La Meije - Massif des Écrins range
verticalScale: 1.0
horizontalScale: 1.0
area:
center:
latitude: 45.005
longitude: 6.308
extentX: 2000
extentY: 2000
54 changes: 47 additions & 7 deletions examples/processes/full.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ heightmaps:
default: 0
water:
default: 0
snowfields:
default: 0

forEachTile:

Expand Down Expand Up @@ -54,9 +56,9 @@ forEachTile:
processor:
type: geoToolsVector

fetchWater:
fetchHydrographic:
type: fetchData
modelType: water
modelType: hydrographic
provider:
type: wfs
url: https://data.geopf.fr/wfs/wfs
Expand Down Expand Up @@ -91,11 +93,15 @@ forEachTile:

flattenWater:
after:
- fetchWater
- fetchHydrographic
- setAltitude
type: copyHeightmap
models:
type: water
type: hydrographic
filter:
not:
metadata: nature
equals: "Glacier, névé"
from:
localMin: ground
range: 9
Expand Down Expand Up @@ -187,18 +193,37 @@ forEachTile:
place: *forest-tree2

populateWaterPresence:
after: fetchWater
after: fetchHydrographic
type: copyHeightmap
models:
type: water
type: hydrographic
filter:
not:
metadata: nature
equals: "Glacier, névé"
from: 1
to: water

populateSnowfieldsPresence:
after: fetchHydrographic
type: copyHeightmap
models:
type: hydrographic
filter:
metadata: nature
equals: "Glacier, névé"
from: 1
to: snowfields
Comment on lines +207 to +216

@indyteo indyteo May 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi passer par une heightmap comme pour l'eau alors qu'on ne fait pas d'applanissement ? On pourrait faire beaucoup plus simple en faisant comme avec les squares ou les étendues d'herbe, c'est-à-dire laisser le sol se générer, et l'écraser avec un nouveau sol (en glace) à la place


computeWaterDepth:
after: populateWaterPresence
type: copyHeightmap
models:
type: water
type: hydrographic
filter:
not:
metadata: nature
equals: "Glacier, névé"
from:
remap:
manhattan: water
Expand Down Expand Up @@ -235,6 +260,21 @@ forEachTile:
- put: *voxel-air
at: [ 0, 0, 1..12 ]

renderSnowfields:
after:
- renderGround
type: renderHeightmap
minimum:
sum:
- ground
- 1
- product: [ -5, snowfields ]
maximum: ground
place:
structure:
- put: *voxel-snowfields
at: [ 0, 0, 0 ]
Comment on lines +263 to +276

@indyteo indyteo May 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'autant plus qu'ici, au lieu d'un render heightmap, avec un min/max compliqué, tu aurais une simple structure de 1x1x5 de glace posée à la hauteur du sol, avec le render surfaces sur les bons models


path:
after:
- fetchRoads
Expand Down
Loading