Fix WMS shift and margins - #198
Merged
Merged
Conversation
[Maven Build Status]📑 Commit: 📦 Download artifact: Generator.jar |
pyrollo
force-pushed
the
pyr/fix-wms
branch
4 times, most recently
from
July 10, 2026 15:10
ea1b379 to
d58c8b3
Compare
Contributor
Author
|
There are still some tests to perform on matrix/vector alignment (not sure of +/- 0.5 adjustments). |
indyteo
reviewed
Aug 4, 2026
Contributor
Author
|
Vérifier l'envelope Vecteur à laquelle il manque peut être quelque chose. |
pyrollo
force-pushed
the
pyr/fix-wms
branch
5 times, most recently
from
September 2, 2026 15:27
24a2180 to
23a42e5
Compare
indyteo
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix a bug in WMS processing when angle was not 0/90/180/270. In corners
Technical changes
TODOs
(later) : Makes processor tell provider which margin it needs for interpolation (hardcoded for now)
Self-checks
The code has unit tests associatedThe code has Javadoc Comments associatedComplex / Unexpected code is explained / justified with a small commentRelevant documentation inside the/docsfolder has been updatedAll examples inexamples/work the same (or have been adapted if subject to changes in this PR)The texts have been proofread (documentation, error messages, logs, comments...)