Skip to content

Update README.md with JDK version information - #63

Open
esgn wants to merge 1 commit into
mainfrom
esgn-patch-readme
Open

Update README.md with JDK version information#63
esgn wants to merge 1 commit into
mainfrom
esgn-patch-readme

Conversation

@esgn

@esgn esgn commented Nov 19, 2024

Copy link
Copy Markdown
Member

Type of modification

Documentation

Issue

None

Changes

Adding information about JDK version to README.md.

Feature description

Adding information about JDK version to README.md.

Technical changes

None

Showcase

Had to install a new version of openjdk to build the generator (was running openjdk 11 by default on ubuntu 22.04)

Reason

Might help newcomers.

@naulan-chrzaszcz

naulan-chrzaszcz commented Nov 19, 2024

Copy link
Copy Markdown
Member

Le format du commit n'est pas bon, il faut plutôt ecrire :

docs(readme): Update JDK version information

Un truc du genre : <type>[optional scope]: <description>

Conventional Commit Messages: https://gist.github.com/qoomon/5dfcdf8eec66a051ecd85625518cfd13

@naulan-chrzaszcz naulan-chrzaszcz added size: tiny Really small change, can be reviewed very quickly type: documentation Improvements or additions to documentation labels Nov 19, 2024
Comment thread README.md Outdated
@esgn
esgn force-pushed the esgn-patch-readme branch from ef15780 to 4f1338f Compare November 19, 2024 16:50
@esgn
esgn force-pushed the esgn-patch-readme branch from 60f7c89 to ffc6fd9 Compare November 20, 2024 09:21

@pyrollo pyrollo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour l'instant, il faudrait plutôt mettre ça dans RUN.md

Mais effectivement, l'articulation README/Run est à revoir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: tiny Really small change, can be reviewed very quickly type: documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants