Upgrade syn to 3 (bump msrv 1.70 -> 1.71) - #188
Draft
jakobhellermann wants to merge 1 commit into
Draft
Conversation
illicitonion
left a comment
illicitonion
left a comment
Owner
There was a problem hiding this comment.
Thanks for putting this together! I'd be happy to accept it and bump the MSRV, but for maximum compatibility would setting the version range to >=2, <4 work for your use-case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can reduce dependencies if you have syn 3 already in the tree.
syn3.0 has a MSRV of1.71, which is why this is marked as draft.1.71 is from Jul 13, 2023, but feel free to close if you don't want to bump it.