Bump agent-controller chart to 0.4.0 (0.3.0 was overwritten by #198) - #200
Open
DavidNic11 wants to merge 1 commit into
Open
Bump agent-controller chart to 0.4.0 (0.3.0 was overwritten by #198)#200DavidNic11 wants to merge 1 commit into
DavidNic11 wants to merge 1 commit into
Conversation
#198 added the temporal-engine subchart as a new dependency but left `version: 0.3.0` alone, and release.yml's own comment says why that matters: # Charts are pushed under their Chart.yaml `version` -- OCI tags are # mutable, so pushing again at the same version overwrites that tag # rather than creating a new one. Bump `version` in the relevant [chart] So the published 0.3.0 tag was overwritten with a chart that has a dependency the original 0.3.0 did not. Anyone who pinned `--version 0.3.0` now resolves something materially different from what they pinned. My omission in #198. Minor rather than patch: a new subchart is a feature, and it is additive — `temporal-engine.enabled` defaults to false, so 0.4.0 renders identically to the original 0.3.0 unless someone opts in. Chart.lock was stale for the same reason: it never listed temporal-engine, so its digest no longer matched Chart.yaml. Regenerated with `helm dependency update`, which also refreshed the open-webui/nats entries it locks. Same three files the last version bump touched (b756db6). Verified: packages as agent-controller-0.4.0.tgz, helm lint clean. Not bumped here: the agent-orchestrator subchart, which is unchanged on main. The draft that enables the engine (#199) modifies it, so that PR needs its own bump of both charts when it lands. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018Uj1SJ41DJJ8woZM7fd3DQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
charts/agent-controllerfrom0.3.0to0.4.0and regeneratesChart.lock.Why this is a fix, not housekeeping
#198 added the
temporal-enginesubchart as a new dependency but leftversion: 0.3.0alone.release.yml's own comment explains the consequence:So the published
0.3.0tag was overwritten with a chart that has a dependency the original0.3.0didn't. Anyone who pinned--version 0.3.0now resolves something materially different from what they pinned.That was my omission in #198, and it's the reason this is worth doing promptly rather than folding into a later PR.
Minor, not patch
A new subchart is a feature. It's also additive —
temporal-engine.enableddefaults tofalse, so0.4.0renders identically to what0.3.0originally rendered unless someone opts in. Nobody upgrading gets new behaviour by accident.Chart.lock was stale for the same reason
It never listed
temporal-engine, so its digest no longer matchedChart.yaml. Regenerated withhelm dependency update, which also refreshed theopen-webui/natsentries it locks. Same three-file shape as the last version bump in this repo (b756db6: umbrellaChart.yaml,Chart.lock, and the subchart that changed).Verified
helm package→agent-controller-0.4.0.tgzhelm lintclean.gitignore:32) and were removed rather than committedNot bumped here
The
agent-orchestratorsubchart, which is unchanged onmain— #197 changed the app, not its chart. The draft that enables the engine (#199) does modify it, so that PR needs its own bump of both charts when it lands. Flagged there rather than pre-empted here.🤖 Generated with Claude Code
https://claude.ai/code/session_018Uj1SJ41DJJ8woZM7fd3DQ