Send clientIdentifier with asset list and config requests - #688
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe page load handler resolves a client identifier from the URL or persisted store. Configuration and asset requests now receive that identifier. ChangesClient Identifier Flow
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds the client identifier to asset-list and configuration requests, including the first visit path, without changing server behavior. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@immichFrame.Web/src/routes/`+page.ts:
- Line 9: Update the clientIdentifier initialization in the page load flow to
treat an empty or missing client query parameter as absent, falling back to
get(clientIdentifierStore) instead of preserving ''.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 7064fd4b-f004-403c-a920-f26f9e725f2c
📒 Files selected for processing (2)
immichFrame.Web/src/lib/components/home-page/home-page.svelteimmichFrame.Web/src/routes/+page.ts
The web client sends the clientIdentifier on asset detail, image, video, weather and calendar requests, but not on GET /api/Asset and GET /api/Config. Both endpoints already accept the parameter.
This passes the persisted identifier on both calls. The config load also reads the ?client= URL parameter directly, since it runs before the home page persists it, so the identifier is correct on the very first visit.
No server behavior changes, the parameter is currently only used for logging.
Summary by CodeRabbit