feat: show only assets in album - #690
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds ChangesAlbum asset filtering
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ServerSettings
participant PooledImmichFrameLogic
participant AlbumAssetsPool
participant Immich
ServerSettings->>PooledImmichFrameLogic: provide ShowOnlyAssetsInAlbums
PooledImmichFrameLogic->>AlbumAssetsPool: create album-only pool
AlbumAssetsPool->>Immich: request album IDs
Immich-->>AlbumAssetsPool: return album IDs
AlbumAssetsPool->>Immich: request assets for each album
Immich-->>AlbumAssetsPool: return album assets
AlbumAssetsPool-->>PooledImmichFrameLogic: return deduplicated assets
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/docs/getting-started/configurationV1.md`:
- Line 21: Update the ShowOnlyAssetsInAlbums description in the V1 configuration
table to state that enabling it selects assets from all albums and ignores the
Albums setting, while ExcludedAlbums continues to apply.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 481688bf-ab17-41f2-8f8b-5005b226df39
📒 Files selected for processing (12)
ImmichFrame.Core.Tests/Logic/Pool/AlbumAssetsPoolTests.csImmichFrame.Core/Interfaces/IServerSettings.csImmichFrame.Core/Logic/Pool/AlbumAssetsPool.csImmichFrame.Core/Logic/PooledImmichFrameLogic.csImmichFrame.WebApi.Tests/Resources/TestV1.jsonImmichFrame.WebApi.Tests/Resources/TestV2.jsonImmichFrame.WebApi.Tests/Resources/TestV2.ymlImmichFrame.WebApi.Tests/Resources/TestV2_NoGeneral.jsonImmichFrame.WebApi/Helpers/Config/ServerSettingsV1.csImmichFrame.WebApi/Models/ServerSettings.csdocs/docs/getting-started/configuration.mddocs/docs/getting-started/configurationV1.md
closes #689
I'm using this version in my local server and it seems to work as expected 🚀
Note: it was implemented by Codex, and reviewed and tested by myself. The implementation seems quite trivial.
Summary by CodeRabbit
New Features
Documentation