transpile: Refactor and improve address-of handling - #1982
Draft
Rua wants to merge 12 commits into
Draft
Conversation
Rua
force-pushed
the
array-decay-refactor
branch
2 times, most recently
from
August 24, 2026 08:24
0f13150 to
70bcccb
Compare
Rua
changed the title
Rua
force-pushed
the
array-decay-refactor
branch
5 times, most recently
from
August 25, 2026 14:38
39bc23c to
938ab27
Compare
Rua
changed the title
Rua
force-pushed
the
array-decay-refactor
branch
4 times, most recently
from
August 25, 2026 17:00
8846fc0 to
509de7a
Compare
Rua
force-pushed
the
array-decay-refactor
branch
from
August 26, 2026 09:59
509de7a to
2f12e6b
Compare
Rua
force-pushed
the
array-decay-refactor
branch
from
August 26, 2026 10:02
2f12e6b to
e850d52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make_cast#1984This PR does a few things that more or less depend on each other:
ptr::from_ref, which is now available in the currently used nightly. It's still unstable there, but it's stable in Rust 2024 so it shouldn't be much of an issue to use it?convert_address_of_commonhandles casting after the borrow operation. It now compares the pointee types and casts only if actually needed.decay_ref. It was a bit of a deadweight anyway since address-of was changed to use raw borrows. Usingfrom_refmakes it completely unnecessary.